search

franzliedke / whoops-middleware

PSR-15 compatible middleware for Whoops, the pretty error handler
MIT License
28 stars 10 forks source link

Adding (needed) Stratigility interface #3

Closed moufmouf closed 8 years ago

moufmouf commented 8 years ago

The ErrorMiddleware (that is designed to work with Stratigility) needs to have 4 required parameters if we want it to be detected as an error middleware by Stratigility. Otherwise, it is detected as a normal middleware and breaks.

It is because of these lines of code:

https://github.com/zendframework/zend-stratigility/blob/61adbe76af9a3a1f5d2e5df7b5182daa0cf472d4/src/Dispatch.php#L61-L70

I simply removed the "= null" from the 4th parameter to make it required.

franzliedke commented 8 years ago

Thank you! I squash-merged it.

franzliedke commented 8 years ago

Will push a new release in a few seconds.

moufmouf commented 8 years ago

:+1: