search

frappe / bench

CLI to manage Multi-tenant deployments for Frappe apps
https://frappeframework.com/docs/user/en/bench
GNU General Public License v3.0
1.36k stars 1.19k forks source link

bench restart does not work on frappe_docker #1436

Open sibidharan opened 1 year ago

sibidharan commented 1 year ago

I made a production setup with frappe_docker, and it was all working fine until I installed healthcare module. Once I did that, I was getting "Module Not Found 'healthcare'" and its reported here: https://github.com/frappe/health/issues/190

Usually to solve such issues when Python is modified inside the production, we set development-mode to 1 and restart bench and things work.. But here inside frappe_docker, bench restart throws WARN: restart failed: Couldn't find supervisorctl in PATH

athul commented 1 year ago

Hi,

You can try maybe a docker-compose restart to restart containers which is kinda same as that of bench restart. But if you're using erpnext with other apps for frappe, I would suggest to use a custom image than install apps in the base image.

You can read more about custom images/apps : https://github.com/frappe/frappe_docker/blob/main/docs/custom-apps.md

It might see tedious first but you can build images on the fly with GH actions or any CI systems.

sibidharan commented 1 year ago

Is there a way to install ERPNext without Docker like old days?

The old easy_install script without docker is still available? So that I can use bench restart! Docker Compose Restart does not pick python code changes like 'bench restart' does. Or am I missing something?

revant commented 1 year ago

Docker Compose Restart does not pick python code changes like 'bench restart' does

https://github.com/frappe/frappe_docker/wiki/Frequently-Asked-Questions#how-to-install-official-or-custom-apps

Any application code changes are part of custom image. Re-build image and restart containers with new image.

Is there a way to install ERPNext without Docker like old days?

Try manual installation. There is official documentation for manual steps. There are many independent blog posts and posts on forum related to manual installation.