Closed dependabot[bot] closed 1 year ago
Leaving this open as a reminder to bump electron version manually.
@18alantom what effort is required to upgrade it manually? Would love to help.
@njmulsqb you'd have to manually upgrade through the electron versions to see what breaks, just running the CI scripts should be fine. Afaik, the node-abi mismatch starts from version 20 onwards.
One of the main reasons why this wasn't done is cause of end of support for older versions of windows: https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice
Note, if you're attempting this, I'd suggest bumping electron to the latest as due to the electron release cadence, version 23 has reached end of support.
Superseded by #751.
Bumps electron from 18.3.7 to 22.3.21.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
2dee878
fix: avoid package.json check on built-in modules (#39425)b026a66
ci: fix hang when validating AppVeyor artifacts (#39398)7a4948b
chore: cherry-pick 4 changes from Release-0-M115 (#39269)878f184
fix: do not resolve electron entrypoints on disk (#39248)bbe9d8b
ci: fail appveyor build if artifacts are missing (#39218)047fdbf
build: disable unneeded depot_tools update on Windows CI (#39017)1f91895
chore: cherry-pick 4 changes from Release-3-M114 (#38949)4ade2a6
build: use Xcode 13.4.1 (#38822)a68e328
chore: cherry-pick 5 changes from Release-2-M114, Release-1-M110 and Release-...047f474
chore: cherry-pick 7 changes from Release-0-M114 (#38534)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show