search

frappe / books

Free Accounting Software
https://frappe.io/books
GNU Affero General Public License v3.0
2.68k stars 614 forks source link

fix: #808 Payment referenceType NULL due to bad migration #809

Closed mildred closed 5 months ago

mildred commented 5 months ago

Fix #808

Isaac-GC commented 5 months ago

LGTM!

A good point was raised here: https://github.com/frappe/books/issues/808#issuecomment-1895632861

Taking a second look jic

Isaac-GC commented 5 months ago

Hi @mildred,

The patch was looking to be marking both types, sales and payment, as SalesInvoice's. Please see the above code in the review that should fix both types of invoices.

If also possible, could I please have you update/add the package.json with version code 0.20.1?