search

frappe / books

Free Accounting Software
https://frappe.io/books
GNU Affero General Public License v3.0
2.68k stars 614 forks source link

Fixing printToPDF from electron window #827

Closed Isaac-GC closed 5 months ago

Isaac-GC commented 5 months ago

Fixing an issue with Printing to a PDF.

Hi @mildred @18alantom

Testing this fix on local devices (linux, windows, and mac arm) it looks fine, but requesting verification JIC.

Thanks!

Isaac-GC commented 5 months ago

It seems the PDF exports page size are off in v0.21.0, do you think that is from a dependency update?

Most probably, I could not save a PDF with your branch until I updated the dependencies... and it fixes the page size issue

Correct --> It partly has to due to the dependency updates and specifically, the parameter option changes in the window.printToPDF. While the pdf's generated DO actually contain the expected contents... the actual contents are incredibly tiny due to the changes... But are fixed