search

frappe / books

Free Accounting Software
https://frappe.io/books
GNU Affero General Public License v3.0
2.68k stars 614 forks source link

Changed Payment Reference Type #865

Closed Sutiksh27 closed 4 months ago

Sutiksh27 commented 4 months ago

Reasoning: If the outstanding amount is negative means that amount was deducted/debited from the account hence the reference type should be PurchaseInvoice instead of SalesInvoice.

Result - The "FromAccount" in both role party is displaying the same menu as the single role party. Screenshot 2024-03-01 130526 Screenshot 2024-03-01 130617

Test Supplier 2 has "both" as role

Isaac-GC commented 4 months ago

Hi @Sutiksh27 --> A PR was merged for the same issue https://github.com/frappe/books/pull/865

Closing this PR, but gonna add your name to the other one as well