frappe / changemakers

Beneficiary Management Platform, built on Frappe Framework.
https://frappe.io/products/changemakers
GNU Affero General Public License v3.0
74 stars 31 forks source link

Adding child table payment Details #130 #133

Closed maniamartial closed 1 year ago

maniamartial commented 1 year ago

Created a child table "payment details". Also created a field total amount which gets the sum of amount before save Issue #130

maniamartial commented 1 year ago

Changes done

NagariaHussain commented 1 year ago

Oh no, you didn't put the table in Case doctype? @maniamartial

And also no total amount field, but you are still trying to access it through code 🤦🏼

P.S. Got deployed to prod 🤣

maniamartial commented 1 year ago

No, I did, maybe there is something am not doing right, but the table and total are there, I can access them on my end. Md

NagariaHussain commented 1 year ago

Maybe you didn't go in development mode, this changes were not there in case.json file.

NagariaHussain commented 1 year ago

Fixed here: https://github.com/frappe/changemakers/commit/3899606cc6308b05aeaa6115a6aac319a995e91a

NagariaHussain commented 1 year ago

Also, we have a "Non Negative" property on field which you can use in order to make a currency/float/int field non-negative instead of writing the validation yourself:

CleanShot 2023-10-20 at 11 20 15@2x
NagariaHussain commented 1 year ago

I didn't check it on my local, should have done that. Thanks for the contribution btw!

maniamartial commented 1 year ago

Also, we have a "Non Negative" property on field which you can use in order to make a currency/float/int field non-negative instead of writing the validation yourself:

CleanShot 2023-10-20 at 11 20 15@2x

Thanks, I just realized that yesterday after watching your video.

maniamartial commented 1 year ago

I didn't check it on my local, should have done that. Thanks for the contribution btw!

Sure, I am 2 months old in frappe and ERPNext dev, I hope to contribute more