y negative value should not on the top

[lawrencesong]

Expected Behaviour

y negative value should be always on the bottom. Or an option to make in on the bottom.

Actual Behaviour

y negative value is on the top and positive value is on the top.

Steps to Reproduce:

• abs of max negative value > max postive value

NOTE: Add a GIF/Screenshot if required.

Frappé Charts version: 0.0.8

[travisNeel]

Submitted PR with fix

[lawrencesong]

Thanks for submitting the PR @travisNeel . Do you know when the PR can it be merged? I need this fix as it's caused a bug in production.

[lawrencesong]

@travisNeel This bugs can be reproduced in v1 as well.

[agateblue]

Encountered this in frappe 1.4.1, e.g with the following chart:

Chart options:

{
  "data": {
    "datasets": [
      {
        "values": [
          7,
          1,
          4,
          1,
          3,
          -4,
          -1,
          -7,
          2,
          5,
          4,
          1,
          -1,
          5,
          4,
          -3,
          -3,
          -1,
          2,
          3,
          1,
          -5,
          1,
          5,
          2,
          -2,
          -1,
          -8,
          -5,
          2
        ],
        "name": "mood",
        "chartType": "line"
      }
    ],
    "labels": [
      "2020-04-18",
      "2020-04-19",
      "2020-04-20",
      "2020-04-21",
      "2020-04-22",
      "2020-04-23",
      "2020-04-24",
      "2020-04-25",
      "2020-04-26",
      "2020-04-27",
      "2020-04-28",
      "2020-04-29",
      "2020-04-30",
      "2020-05-01",
      "2020-05-02",
      "2020-05-03",
      "2020-05-04",
      "2020-05-05",
      "2020-05-06",
      "2020-05-07",
      "2020-05-08",
      "2020-05-09",
      "2020-05-10",
      "2020-05-11",
      "2020-05-12",
      "2020-05-13",
      "2020-05-14",
      "2020-05-15",
      "2020-05-16",
      "2020-05-17"
    ]
  },
  "title": "Mood by day",
  "axisOptions": {
    "xIsSeries": true
  },
  "lineOptions": {
    "hideDots": 1
  },
  "height": 300,
  "type": "line",
  "maxSlices": 7,
  "colors": [
    "magenta",
    "orange"
  ],
  "tooltipOptions": {}
}