The PR adds a full circle check to pie chart and donut chart, this is required when a single data point is given to these charts, or when all but one data points have the value zero.
Using the SVGs arc path, one can draw 99.999% of the circle but not a complete circle, this doesn't work because the starting point and ending point of the arc is the same for a circle, so I guess the browser does not bother to draw the SVG, it's similar to drawing a line from (10, 10) to (10, 10) you get no line. Normally it would be wise to use the <circle> tag, but that may require bigger changes and can be a part of a different release, so right now we use a clever hack to solve this problem.
The d attribute will accept and draw all valid path command strings, The trick is to have two arcs, the second one picking up where the first left off and get back to the original arc start point. [ref]
coveralls
commented
5 years ago
Solves https://github.com/frappe/charts/issues/186
Explanation About What Code Achieves:
The PR adds a full circle check to pie chart and donut chart, this is required when a single data point is given to these charts, or when all but one data points have the value zero.
Using the SVGs arc path, one can draw 99.999% of the circle but not a complete circle, this doesn't work because the starting point and ending point of the arc is the same for a circle, so I guess the browser does not bother to draw the SVG, it's similar to drawing a line from (10, 10) to (10, 10) you get no line. Normally it would be wise to use the
<circle>tag, but that may require bigger changes and can be a part of a different release, so right now we use a clever hack to solve this problem.The
dattribute will accept and draw all validpath commandstrings, The trick is to have two arcs, the second one picking up where the first left off and get back to the original arc start point. [ref]Screenshots/GIFs:
Previously as mentioned here https://github.com/frappe/charts/issues/186 the chart would not render at all. After the fix, the rendering in either cases works fine: