Feature/truncate legend dot labels - Githubissues

frappe / charts

Simple, responsive, modern SVG Charts with zero dependencies

https://frappe.io/charts

MIT License

14.94k stars 718 forks source link

Feature/truncate legend dot labels #242

Closed ddoice closed 5 years ago

ddoice commented 5 years ago

Explanation About What Code Achieves:

When using pie charts legends with large numbers will overlap making the legend unreadable.
Changed renderLegend in AggregationChart to pass truncateLegends option.
Changed legendDot signature and logic to truncate the legend.

Screenshots/GIFs:

Before:
After:

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 132

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.158%

Totals
Change from base Build 131:	0.0%
Covered Lines:	29
Relevant Lines:	62

💛 - Coveralls