feat[pie/donut]: custom tooltips for aggregate

riccardogioratoatoms commented 4 years ago

Explanation About What Code Achieves:

This code fixes the issue I had with tooltips with pie charts and donuts charts, like I mentioned it here: frappe#304

Considering the fact that these kind of graph have only 1 value I choose the naming of the function as tooltipOptions.formatTooltip without X or Y like it's possible to do with other kind of graphs.

Screenshots/GIFs:

TODOs:

maybe it would be nice to document this in the docs with a simple example too?
might be usefuel for the "progress" chart too to anyone?

Solves: https://github.com/frappe/charts/issues/136

riccardogioratoatoms commented 4 years ago

Any news on this @scmmishra, would you like me to edit something?

scmmishra commented 4 years ago

Hey @riccardogioratoatoms so sorry for the delay. I've been very busy lately with a few stuffs, I'll definitely review this tomorrow. On the surface it looks good to go, there won't be any changes required it seems.

I'll update the documentation for it as well.

frappe / charts