frappe / charts

Simple, responsive, modern SVG Charts with zero dependencies
https://frappe.io/charts
MIT License
14.9k stars 716 forks source link

Bug: adding `lineOptions: { spline: 1 }` leads to a console error #396

Closed RomkaHorokhov closed 1 year ago

RomkaHorokhov commented 1 year ago

Expected Behaviour

No error in console

Actual Behaviour

Error in console is seen: "Error: attribute d: Expected number, "…0 C 756.004,230 NaN,NaN 848.57,2…"."

Steps to Reproduce:

NOTE: Add a GIF/Screenshot if required. frappe_err frappe_err_details The issue seems to be with the pre-last C in svg's path as shown on the last screenshot

Frappé Charts version: 1.6.2 Codepen / Codesandbox: https://codepen.io/nerveclasp/pen/mdLEamy

uhrjun commented 1 year ago

SVG error seems to only be logged in Chromium (not anything of note its just interesting). Seems to have been caused by the ResizeObserver in commit 12533f3b376328a8437109977910c8f2041572e5. Which is being looked at to revert. Thanks for reporting the issue.