Why do pie-chart and percentage-chart only allows 6 legend points?

frappe / charts

Simple, responsive, modern SVG Charts with zero dependencies

https://frappe.io/charts

MIT License

14.94k stars 718 forks source link

Why do pie-chart and percentage-chart only allows 6 legend points? #85

Closed seebaermichi closed 6 years ago

seebaermichi commented 6 years ago

Expected Behaviour

Pie-chart and percentage-chart should show as much legend-points as segments in the chart.

Actual Behaviour

Pie-chart and percentage-chart only show a max of 6 legend-points.

Steps to Reproduce:

just create a pie-chart or percentage-chart with more than 6 segments
as shown on the docu-page

Frappé Charts version: v0.0.7

fddi commented 6 years ago

I have the same problem .

seebaermichi commented 6 years ago

I could enable custom values for this.max_legend_points in pie-chart and percentage-chart constructor like this: this.max_legend_points = args.max_legend_points || 6; Should I create a pull-request for this enhancement or is there a reason why it shouldn't be more than 6?