search

frappe / datatable

The Missing Javascript Datatable for the Web
https://frappe.io/datatable
MIT License
1.02k stars 164 forks source link

AppendRows #100

Closed mrcandu closed 10 months ago

mrcandu commented 4 years ago

Hi From the docs it isn't obvious what format the data should be in for appendRows Tried many variations, the most obvious being: https://jsfiddle.net/mrcandu/rj8h9cw7/ But nothing is working? Thanks Mat.

ArunMuthuram commented 4 years ago

Hi From the docs it isn't obvious what format the data should be in for appendRows Tried many variations, the most obvious being: https://jsfiddle.net/mrcandu/rj8h9cw7/ But nothing is working? Thanks Mat.

Hi Mat, The data format you are using is right and the reason append rows are not working is due to a bug in code. I have proposed a fix and have raised a pull request. #104

johnlandish commented 3 years ago

has this been fixed?

d-miles commented 10 months ago

@netchampfaris @shariquerik could you merge @ArunMuthuram's change to fix this bug? he submitted pull request #104 (which resolves the issue) over 3.5 years ago now.

netchampfaris commented 10 months ago

@d-miles Thanks for tagging. Fixed now. I don't get much time to work on this. Hoping to find someone who can maintain.

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version 1.17.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: