frappe / datatable

The Missing Javascript Datatable for the Web
https://frappe.io/datatable
MIT License
991 stars 160 forks source link

fix: get content value for specific fieldtypes #169

Closed shariquerik closed 1 year ago

shariquerik commented 1 year ago

Issue: While filtering we always compare the filter string with the formatted value of the cell but some cell takes too much time to get the formatted value which results in a broken page.

For some field types like the Link field we do not have to get formatted value, we can check with the content value. This PR adds a flag while getting the value we pass flag for_filter=true as a fifth parameter. The main logic will be handled based on the flag at the framework side which is through this PR https://github.com/frappe/frappe/pull/20240