Scrolling and Expand/Collapse issue with DataTable

SaiFi0102 commented 5 years ago

I encountered multiple issues trying to use Sales/Purchase Analytics. I already created an issue in erpnext's repo but I later realized it has more to do with DataTable so I'm posting it here too.

When there are too many rows, another scrolling bar pops up... at around the 150 row mark
When you've clicked on a cell in a row that is near the vertical end, you cannot scroll up past a point (maybe the point at which another scrolling bar pops up)
When you collapse the last collapsible row, you cannot expand it again. And there is extra scrolling space below that point even though there aren't any more rows.

The first 2 problems can also be analyzed at https://beta.erpnext.com/desk#query-report/General%20Ledger

netchampfaris commented 5 years ago

@SaiFi0102 ERPNext must be on an older version of DataTable. I think it is updated now. The collapsing problem should be fixed.

The scrolling problem still exists. Will look into it.

jodeq commented 5 years ago

Seems to be my issue here : https://github.com/frappe/frappe/issues/6445 I think the overflow is linked to this issue

frappe / datatable

Scrolling and Expand/Collapse issue with DataTable #47