search

frappe / datatable

The Missing Javascript Datatable for the Web
https://frappe.io/datatable
MIT License
1.02k stars 164 forks source link

Fix header and footer in rtl body direction #56

Open ahmed-madi opened 5 years ago

ahmed-madi commented 5 years ago

Header and footer don't scroll when the body is in rtl direction, and this is because of the different value of scrollLeft in different browsers when the direction is rtl, also - sign should be inside the Template string like this ${-scrollLeft} to be calculated properly in case of rtl body direction because Firefox calculates the value of the scrollLeft in negative when the direction is rtl so translateX need a positive value to move as expected. this pull request fix these issues.

Thank you

ahmadRagheb commented 5 years ago

i test it locally it works fine with me .. but when i use it inside frappe bench and goo to node module and build it doesn't work ?

ahmadRagheb commented 5 years ago

@netchampfaris what do you think?

ahmadRagheb commented 5 years ago

@ahmed-madi there is issue when change the col size it do the ltr not rtl adjustment

ahmed-madi commented 5 years ago

when change the size of columns it goes to LTR not RTL

Please give scenario with steps to reproduce

ahmadRagheb commented 5 years ago

@ahmed-madi i try to make some columns width changes so in RTL the same direction as LTR in width addition .. it should go to right not left

mhbu50 commented 5 years ago

@ahmadRagheb Could You fix the Conflicting files?