frappe / easy_install

Install script for Frappe. ⚠️ This is DEPRECATED and unmaintained. ⚠️
5 stars 8 forks source link

The description say it will work with Debian, however error is returned. #15

Open jalabaya opened 3 years ago

jalabaya commented 3 years ago

Issue: Easy Install

Note: This script works only on GNU/Linux based server distributions, and has been designed and tested to work on Ubuntu 16.04+, CentOS 7+, and Debian-based systems.

This is the error message: Sorry, the installer doesn't support debian gnu/linux. Aborting installation!

Debian 10 on Linode Linux localhost 4.19.0-16-amd64 frappe/bench#1 SMP Debian 4.19.181-1 (2021-03-19) x86_64 GNU/Linux

Looks like the docs need an update.

ToddE commented 2 years ago

when following the directions here (https://jwrober.github.io/erpnext_admin_guide/i-u-b/install) i got a "nicer" error. Seems to support older Debian (Debian 9) but not 10?

Checking System Compatibility...
debian 10 is detected
Install on debian 9 instead
Bench's CLI needs these to be defined!
Run the following commands in shell:
export LC_ALL=C.UTF-8
jd4u commented 2 years ago

The issue is the name of distro. The Debian 10 outputs name as "debian gnu/linux". While the distro name list contains only "debian".

Solution: Split the name and return only first part.

This shall work for other distros too as the first name is always present as per the list of supported_dists

Script: install.py function: get_distribution_info Current Line 126: return current_dist[0].lower(), current_dist[1].rsplit('.')[0] Changed Line 126: return current_dist[0].lower().split()[0], current_dist[1].rsplit('.')[0]

Please team member, update this solution to installer sooner.