frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
103 stars 134 forks source link

Feature Request: Map order Payment Gateway to Payment Account #213

Open meaziz opened 1 year ago

meaziz commented 1 year ago

We stumbled upon a case where we wants to have the payment entry posted to different accounts based on the payment gateway used in shopify..

for example

Payment Gateway Account Name
Cash on delivery 11202 Fullfilment Cash
Credit Card 11203 Credit Card.

or should it map to mode of payment which maps to a cash or bank account.

I would recommend keeping it simple to a bank account..

We can contribute this if we agreed on the specs.

ankush commented 1 year ago

Hello, giving option for gateway -> account seems most flexible for future use cases too. (similar to location->warehouse and tax accounts)

This seems fine. Tag me when you open PR :)

meaziz commented 1 year ago

@ankush tagging you as per your request not sure why haven't we opened the pull request earlier 🥲

azurre931 commented 10 months ago

Will this feature be added soon? Our Bank account don't match in ERPNext because Payment Gateway is always the same.

meaziz commented 10 months ago

We have it in production for 4 months now. It needs minor cleanup before we open a new pull request for it.

And add the proper documentation.

On Wed, Nov 29, 2023 at 7:30 PM azurre931 @.***> wrote:

Will this feature be added soon? Our Bank account don't match in ERPNext because Payment Gateway is always the same.

— Reply to this email directly, view it on GitHub https://github.com/frappe/ecommerce_integrations/issues/213#issuecomment-1832391730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYHTZNGA7LUPZ7SZHIUCBTYG5WM5AVCNFSM6AAAAAARLYFIHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGM4TCNZTGA . You are receiving this because you authored the thread.Message ID: @.***>

azurre931 commented 4 months ago

Do we have any news about this feature? Thank you.

meaziz commented 4 months ago

It is working on a fork maybe we should refine it and open a PR for it.

azurre931 commented 1 week ago

Can you open a PR for it? Thank you!