frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
103 stars 134 forks source link

Amazon MWS integration, sync orders character limit for Title #216

Closed kvt closed 1 year ago

kvt commented 3 years ago

In error log it is showing

Error Log ffa12ac821: 'Title' (<bound method Orders.list_orders of <erpnext.erpnext_integrations.doctype.amazon_mws_settings.amazon_mws_api.Orders object at 0x7f488fdc0860>>) will get truncated, as max characters allowed is 140

barredterra commented 3 years ago

Hi @kvt, thanks for reporting.

kvt commented 3 years ago

Hi @barredterra, Thanks for reply.

ERPNext: v12.13.0 (version-12) Frappe Framework: v12.11.0 (version-12)

STEPS:

Reason: Some of my amazon listings have title more than 140 characters.

barredterra commented 3 years ago

Do you know how long the titles from amazon can get? How many characters should we allow?

kvt commented 3 years ago

it is 200 but amazon can change its policy in future so for safer side can we set 250? Screenshot 2020-11-11 184355

s-aga-r commented 1 year ago

@kvt The Amazon item title length is greater than the ERPNext Item Title (140). However, we have updated to Amazon SP-API where you can define the ERPNext Item field you want to map with the Amazon Item Title.