search

frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
110 stars 145 forks source link

fix(shopify): handle multiple instance of same item in delivery #294

Closed ankush closed 12 months ago

ankush commented 12 months ago

Earlier the code assumed item can only be used once in order. This change now uses fifo type assignment of shopify line items to delivery note line items to only map item code once and then pop it.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (7a5cf2f) 39.65% compared to head (7d663c1) 39.55%.

Files Patch % Lines
ecommerce_integrations/shopify/fulfillment.py 0.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #294 +/- ## =========================================== - Coverage 39.65% 39.55% -0.10% =========================================== Files 68 68 Lines 4406 4417 +11 =========================================== Hits 1747 1747 - Misses 2659 2670 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 12 months ago

:tada: This PR is included in version 1.19.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: