frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
110 stars 144 forks source link

ci: use best practice #331

Closed blaggacao closed 1 month ago

blaggacao commented 1 month ago

@rmehta Could you please adapt the branch protection rules to check for the updated ci actions? Server is old and test have been broken anyway for months. I fixed them here.

rmehta commented 1 month ago

Updated your role to "maintain"

On 02-Oct-2024, at 2:57 PM, David Arnold @.***> wrote:

@rmehta https://github.com/rmehta Could you please adapt the branch protection rules to check for the updated checks? Server is old and test have been broken anyway for months. I fixed them here.

— Reply to this email directly, view it on GitHub https://github.com/frappe/ecommerce_integrations/pull/331#issuecomment-2388023274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABCGLESOY5ZD4JEJTFWRITZZO37HAVCNFSM6AAAAABPGXVDKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGAZDGMRXGQ. You are receiving this because you were mentioned.

blaggacao commented 1 month ago

@rmehta Thanks, unfortunately, that doesn't seem to be "enough" for this configuration. I don't want to escalate my privileges too much, so I'd be very happy if someone from staff could have a quick look:

rmehta commented 1 month ago

updated. check? also updated you to "admin"