Summernote sucks, replace with Trumbowyg

[rmehta]

https://alex-d.github.io/Trumbowyg/

[joolsr]

What's wrong with Summernote out of interest? Just interested in what you consider its faults are. Also it wasn't so long back that Summernote replaced the previous editor .. But good to see improvements continuing ;-)

[dottenbr]

Summernote creates extremely messy HTML which is made worse by some specific code in Frappe which replaces <p> with <div>. I played around with Trumbowyg and it seems to create pretty clean code so yea, all for it!

[giuseppelamatrice]

+1

[netchampfaris]

https://github.com/frappe/frappe/pull/5562

[netchampfaris]

I have tried implementing both Trumbowyg and CkEditor, here's a list of pros and cons. Both lack features we want. Additions welcome.

Trumbowyg:

Pros:

• Depends on jQuery

Cons:

• Trumbowyg depends on contenteditable like any other WYSIWYG editor out there, even summernote which is the source of all problems.
• Not all features of summernote are included like emojis and mentions (will have to write plugins)
• Opinionated widgets and UI which can be overridden by introducing more styles.

---

CkEditor:

Pros:

• Has an abstract MVC architecture over the DOM, so doesn't depend on contenteditable, hence it will render content the same on every browser.
• All of it's styling can be overridden by just changing CSS Variables

Cons:

• Not all features of summernote are included like emojis and mentions (will have to write plugins).
• Build process based on webpack. Cannot be integrated seamlessly with our current setup.

[netchampfaris]

I think we should also have a markdown edit mode like GitHub.

[pratu16x7]

I have tried the Trumbowyg replacement, it's working is similar to Summernote being built upon contentEditable as @netchampfaris pointed out.

The fact that it certainly is less painful can be attributed to its simplicity, but that is accounted for by its lack of features (beware, nearly every level 2 feature, even fonts, tables, and emoji) that will all need plugins.

Haven't tried CKEditor, but based on the pros and cons listed, although it isn't an improvement on the above, it is a winner in being browser agnostic.

[rmehta]

@pratu16x7 @netchampfaris do we have both implemented?

[netchampfaris]

@rmehta Yes, but not merged yet. Also, I have closed my PR for now because webforms still treat the TextEditor separately, so I think we should wait for the new Webforms to get merged before implementing any of the two editors.

[rmehta]

The reason we need more communication 😉

Sent from phone

On 17-May-2018, at 6:44 PM, Faris Ansari notifications@github.com wrote:

@rmehta Yes, but not merged yet. Also, I have closed my PR for now because webforms still treat the TextEditor separately, so I think we should wait for the new Webforms to get merged before implementing any of the two editors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[rmehta]

Finally it was Quill 👍