frappe / erpnext

Free and Open Source Enterprise Resource Planning (ERP)
https://erpnext.com
GNU General Public License v3.0
22.07k stars 7.39k forks source link

TTFB Very Slow #20296

Closed mariotruss closed 4 years ago

mariotruss commented 4 years ago

Problem

Potential Source of Error

We found a pattern, why we think this issue might occur:

Expected Result / Ideas

scmmishra commented 4 years ago

Hi @MarioMeetsWorld

About your observations

Desk is downloading a huge html file containing a json with 10800+ lines of code

It's less than 500kb, it's not much of a problem really.

The actual problem is pre-processing when serving desk.

We recently made a few changes for better caching and less number of queries. It's going to be released soon. (PR: https://github.com/frappe/frappe/pull/9079)

It has been in develop branch for about a month, we're releasing it in version 12 as well. For my test instance with 400 system users with all roles set including system manager, the TTFB reduced from 49 seconds to just over 2 seconds.

It should solve your problem. I'm closing the Issue, update your instance with the next release and it should be fine.

mariotruss commented 4 years ago

@scmmishra Okay, we will do that. Still, what do you think about this? Security Issue/GDRP: Desk contains a HMTL will all user data. Every person with a login could easily get all employee information.