jon-nfc
commented
3 years ago After further investigation, it appears that the GL entries are incomplete. with nothing within the purchase invoice interface that I noticed where I could change it to correct the GL entries.
Code changes made
command ouput from: `docker exec -ti frappe-python sh -c "cd ../apps/erpnext && git diff"` ``` diff diff --git a/erpnext/accounts/general_ledger.py b/erpnext/accounts/general_ledger.py index 25d2cf1..393c347 100644 --- a/erpnext/accounts/general_ledger.py +++ b/erpnext/accounts/general_ledger.py @@ -158,11 +158,14 @@ def round_off_debit_credit(gl_map): precision = get_field_precision(frappe.get_meta("GL Entry").get_field("debit"), currency=frappe.get_cached_value('Company', gl_map[0].company, "default_currency")) + debug_msg = [] debit_credit_diff = 0.0 for entry in gl_map: entry.debit = flt(entry.debit, precision) entry.credit = flt(entry.credit, precision) debit_credit_diff += entry.debit - entry.credit + + debug_msg.append(("voucher: {0} account: {1}, debit: {2}, credit: {3}").format(entry.voucher_no, entry.account, entry.debit, entry.credit) + "\n") debit_credit_diff = flt(debit_credit_diff, precision) @@ -173,7 +176,7 @@ def round_off_debit_credit(gl_map): if abs(debit_credit_diff) > allowance: frappe.throw(_("Debit and Credit not equal for {0} #{1}. Difference is {2}.") - .format(gl_map[0].voucher_type, gl_map[0].voucher_no, debit_credit_diff)) + .format(gl_map[0].voucher_type, gl_map[0].voucher_no, debit_credit_diff) + "\n Debug-GL Entries: " + ("").join(f"\n {msg}" for msg in debug_msg)) elif abs(debit_credit_diff) >= (1.0 / (10**precision)): make_round_off_gle(gl_map, debit_credit_diff, precision) ```Output from changes made above:
``` shell Traceback (most recent call last): File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 19, in savedocs doc.submit() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 929, in submit self._submit() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 918, in _submit self.save() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 285, in save return self._save(*args, **kwargs) File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 337, in _save self.run_post_save_methods() File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 997, in run_post_save_methods self.run_method("on_submit") File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 859, in run_method out = Document.hook(fn)(self, *args, **kwargs) File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1148, in composer return composed(self, method, *args, **kwargs) File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1131, in runner add_to_return_value(self, fn(self, *args, **kwargs)) File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 853, inAccount 2-1110-01 is a liability, 1-7121-99 is an asset account with 6-0510 being an expense account.
Is there a configuration setting somewhere that I have missed? It appears as though the additional charge does not get charged against a supplier, for example a postage company.
ankush
matthewdwatkins
deepeshgarg007
Description of the issue
When I create a purchase invoice (in USD company currency is AUD), and add 'additional charges' in this case shipping. I can save the invoice however I'm unable to submit the invoice as a message pops up saying
Debit and Credit not equal for Purchase Invoice #ACC-PINV-2021-00093. Difference is 7.77.7.77 is the value in AUD for the additional charges. however this issue has also occured creating the invoice in the company currency. if no additional charges are added the invoice will submit.I'm unable to submit any of these invoices that have additional charges included in them. currently this prevents us from progressing on a large number of invoices.
I have looked through all options in the PI interface in an attempt to check if I have caused the error, however it appears everything is correct.
Context information (for bug reports)
Output of
bench versionSteps to reproduce the issue
Observed result
message pop-up
Debit and Credit not equal for Purchase Invoice #ACC-PINV-2021-00093. Difference is 7.77.and the invoice is not submitted.Expected result
Stacktrace / full error message
stack trace below is one single action, clicking on the 'Submit' button for the PI.
Additional information
My setup consists of using docker images see below for details on debian 10. I use the frappe images as the base images and build images that include all of the required apps in them.
OS version / distribution,
ERPNextinstall method, etc.