search

frappe / erpnext

Free and Open Source Enterprise Resource Planning (ERP)
https://erpnext.com
GNU General Public License v3.0
20.22k stars 7.06k forks source link

JS field visibility issues on Purchase Receipt Item etc. #36921

Open bosue opened 1 year ago

bosue commented 1 year ago

Information about bug

For some reason, the first Purchase Receipt Item automatically created with a new Purchase Receipt will always show all conditionally visible fields.

This includes e.g. the redundant amounts in company currency even though the Purchase Receipt’s currency is the same (both EUR):

IMG_1386

Any further, manually added Purchase Receipt Items will however not show any conditionally visible field.

Notably, even after switching the Purchase Receipt’s currency to USD, the amounts converted to company currency (EUR) are missing:

IMG_1387

Same thing for Sales Receipts btw.

From what I can see now, this looks like a problem with the JS logic ~and/or compatibility with Safari.~

~As soon as I’m back to my Linux workstation, I will figure out if the problems are platform-dependent or not. I guess they are, because otherwise the bug would have been ironed out much earlier.~

~Either way, we should really reduce our dependency on custom JS apart from a select couple of behaviors generically provided by Frappe and well-tested on all platforms!~

Module

other

Version

Frappe dev / ERPNext dev JS run on Safari / iPadOS 16.6 or Firefox / Linux or Edge / Windows

Installation method

FrappeCloud

bosue commented 1 year ago

Definitely no Safari problem. The exact same display error appears on both Firefox / Linux and Edge / Windows.