frappe / erpnext

Free and Open Source Enterprise Resource Planning (ERP)
https://erpnext.com
GNU General Public License v3.0
18.1k stars 6.88k forks source link

Validation checks on Supplier Quotation against original RFQ #41091

Open thenbdev opened 4 months ago

thenbdev commented 4 months ago

Information about bug

Scenario: I am able to add a supplier quotation without checking if the quotation actually fulfils my order. Let's say I have ordered 20 cameras and 40 batteries. There are 15 suppliers who can fill in their prices.

There are 2 important validations/notifications we should have:

Module

buying

Version

Frappe - 15.21.0 Erpnext - 15.19.2

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

casesolved-co-uk commented 3 months ago

The process should work:

So when you say "checking if the quotation actually fulfils my order" do you actually mean RFQ? Because the order happens afterward.

thenbdev commented 3 months ago

I am looking at Supplier Quotation and Purchase Order. When a supplier gives a quotation, the supplier, in the current construct can drop out some item(s), from RFQ. When analysing supplier quotations for generating a PO, a user currently needs to validate all the supplier quotation to identify if item(s) is/are missing.

casesolved-co-uk commented 3 months ago

Then I think you need to revise your issue description to make it clear the validation needs to happen against the original RFQ (not order)

thenbdev commented 3 months ago

the description is to validate supplier quotation. I have updated the description to add that we are comparing against original RFQ.