search

frappe / frappe-ui

A set of components and utilities for rapid UI development
https://ui.frappe.io/
MIT License
270 stars 114 forks source link

`fields` prop is not wired in ConfirmDialog #189

Closed ruchamahabal closed 3 weeks ago

ruchamahabal commented 1 month ago

https://github.com/frappe/frappe-ui/blob/a5147184122d7d8fd2d71af7caef2395708758f5/src/components/ConfirmDialog.vue#L1-L17

Remove it? Keep & wire it? Doesn't make sense to add fields in a confirm dialog anyway. This can be removed.

nextchamp-saqib commented 1 month ago

Remove it, this isn't used anywhere