frappe / frappe

Low code web framework for real world applications, in Python and Javascript
https://frappeframework.com
MIT License
7.11k stars 3.4k forks source link

Link on internal self hosted server in email can not be removed #14792

Open vladav opened 9 years ago

vladav commented 9 years ago

When sending Quotation, PO or SO by email with PDF attached, ERPnext adds in email line with "View this from your browser" with the link to the document on internal ERPnext server (self-hosted installation). Customers can not access the file (since self-hosted server is internal and not published) and it is a bit consusing for some of them. It is not possible to remove this line/link!

Ref: https://discuss.erpnext.com/t/sending-quoatation-po-so-by-email-without-link-to-the-self-hosted-erpnext/6600

gabtzi commented 9 years ago

Hi, I'd like to second this because when ERPNext is used in an internal server the "View this from your browser" link causes spamassassin to give a -1 score due to 404 links in the email. You can test it in mail-tester.com as well to verify this.

I know this might seem trivial but I assure you it's not because most corporate clients use self-hosted emails with very strict spam controls so the email gets immediately flagged as spam ending up in Spam folder where it won't be seen. Worst case scenario the email won't even be delivered.

Temporarily I commented out the line at

apps/frappe/frappe/templates/emails/print_link.html

but it would be nice to see it as an option.