frappe / frappe

Low code web framework for real world applications, in Python and Javascript
https://frappeframework.com
MIT License
7.29k stars 3.45k forks source link

Default value for naming_series must be in the list of options. #18078

Closed KhaledBinAmir closed 2 years ago

KhaledBinAmir commented 2 years ago

Description of the issue

When updating Document Naming Settings an error message showing up Default value for naming_series must be in the list of options.

I figured out the same thing happening when try to update naming_series in Customize Form, maybe the system is trying to save default option before updating the list options.

After clearing default option in Customize Form, the problem was resolved for me. Document Naming Settings - 10 September 2022

Output of bench version

bench_manager 0.0.1
erpnext 14.1.0
frappe 14.6.0
hrms 0.0.1
payments 0.0.1
ankush commented 2 years ago

You've already set some default which isn't present in naming series options anymore. I guess we can just remove default too while updating.

Go to customize form > employee and see default on naming series.

KhaledBinAmir commented 2 years ago

You've already set some default which isn't present in naming series options anymore. I guess we can just remove default too while updating.

Thanks for your prompt response

No, I did not set default in customize form. since naming_series options cannot be changed in customize form and a default value which is not listed in options is not allowed, I cannot really set one.

ankush commented 2 years ago

@hiimkhaled you CAN update defaults from customized form.

What has happened is there used to be some naming series before which was set as default and now that you're removing it, it's not letting you do that.

Screenshot 2022-09-10 at 12 57 00 PM Screenshot 2022-09-10 at 12 57 10 PM