frappe / frappe

Low code web framework for real world applications, in Python and Javascript
https://frappeframework.com
MIT License
7.26k stars 3.45k forks source link

Global Search doesn't show results #21263

Closed TurkerTunali closed 1 year ago

TurkerTunali commented 1 year ago

Description of the issue

If I search for "ege" in v13 awesomebar, it lists records within the dialog. v14 opens a doctyple list and never displays the search dialog.

Context information (for bug reports)

Output of bench version

ecommerce_integrations 1.15.4
erpnext 14.25.1
frappe 14.36.3
hrms 15.0.0-dev
payments 0.0.1

Steps to reproduce the issue

v13 https://github.com/frappe/frappe/assets/710051/119c9720-5c49-47fd-921b-47c981116478

v14 https://github.com/frappe/frappe/assets/710051/41e7e1a8-27db-4263-8f3e-8d84f7755eba

1.Enter "test" in the awesomebar and press enter.

Observed result

Searching for "test" directs me to "/app/query-report/Item Price Stock" Searching for "ege" directs me to "Email Digest".

Expected result

Search dialog should be shown.

Stacktrace / full error message

None

Additional information

If I write test, "Search for test ↵" option doesn't listed, so dialog never shown. If I write test* then "Search for test ↵" option is listed and dialog displayed.

OS version / distribution, Frappe install method, etc. Ubuntu 22. Manual install.

ankush commented 1 year ago

@TurkerTunali this isn't a bug, because ege is now matching with some value it's highlighted so pressing enter will go to that instead of opening "Global Search"

You can explicitly open global search by clicking on "Search for ege"

ankush commented 1 year ago

ref: https://github.com/frappe/frappe/pull/16478

TurkerTunali commented 1 year ago

@TurkerTunali this isn't a bug, because ege is now matching with some value it's highlighted so pressing enter will go to that instead of opening "Global Search"

You can explicitly open global search by clicking on "Search for ege"

"Search for ..." option had the highest priority in v13 so we can easily show the dialog. v14 it is shown at the very end. It is not convenient in my opinion.

ankush commented 1 year ago

@TurkerTunali there's no way to handle both. Improving search matching using fuzzy searches will show more matches and hence Search for will get pushed down.