search

frappe / frappe

Low code web framework for real world applications, in Python and Javascript
https://frappeframework.com
MIT License
7.25k stars 3.44k forks source link

OAuth2 `get_token` response doesn't have `exp` key in jwt token #23334

Open JamshedAlamQaderi opened 11 months ago

JamshedAlamQaderi commented 11 months ago

Description of the issue

I am trying to use OAuth2 client in android and i was getting error. So, when i was debugging with breakpoints then i've found that id_token is not able to parse because exp key is not available in jwt token from get_token endpoint

Context information (for bug reports)

Output of bench version

(paste here)

Steps to reproduce the issue

1. 2. 3.

Observed result

Expected result

Stacktrace / full error message

(paste here)

Additional information

OS version / distribution, Frappe install method, etc. Frappe Version: v13.58.10 ERPNext Version: v13.52.12

revant commented 11 months ago

You may need to send a PR to backport it to v13

https://github.com/frappe/frappe/blob/ddd24ccb300ae52e423044b5390207f2ea841324/frappe/oauth.py#L334

JamshedAlamQaderi commented 11 months ago

So, if it's available in v14 then i would love to upgrade. but my erpnext depends on other modules like education, service, non-profit. I have tried to install them but not working. Is there any way to make them work in v14?