search

frappe / frappe_docker

Docker images for production and development setups of the Frappe framework and ERPNext
MIT License
1.52k stars 1.4k forks source link

Documentation variables outdated #1369

Closed r1ckr closed 5 months ago

r1ckr commented 7 months ago

Description of the issue

In the documentation mentions the variable FRAPPE_VERSION, but in the example.env file it doesn't exists, instead it is ERPNEXT_VERSION.

I think the change is pretty simple, just change the variable in the example file to FRAPPE_VERSION.

revant commented 7 months ago

Please send PR.

r1ckr commented 7 months ago

Sent

gparent commented 7 months ago

My understanding is that ERPNEXT_VERSION is version of the ERPNext Docker image that is pulled when you are not building your own, whereas FRAPPE_BRANCH and FRAPPE_PATH are used for the Frappe framework repo and version. Is this correct?

r1ckr commented 7 months ago

Then the documentation is the one that needs to be updated?

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale. You have a week to explain why you believe this is an error.