search

frappe / frappe_docker

Docker images for production and development setups of the Frappe framework and ERPNext
MIT License
1.52k stars 1.4k forks source link

#1402 Environment variables for custom image #1403

Closed 0yeifer closed 5 months ago

0yeifer commented 6 months ago

Details

This pull request addresses the need highlighted in the issue for enhancing the customization process within Frappe Docker deployments. The current method of manually modifying the compose.yaml file for custom applications, as described in the issue, can potentially lead to challenges in version control and file integrity.

To alleviate this, I propose the introduction of environment variables, including CUSTOM_IMAGE, CUSTOM_TAG, PULL_POLICY, HTTP_PUBLISH_PORT and HTTPS_PUBLISH_PORT, which users can leverage to customize their deployments seamlessly. This approach not only simplifies the customization process but also enhances the maintainability and consistency of Frappe Docker configurations.

By incorporating this feature, users can define their custom image names and tags directly through environment variables, facilitating smoother deployments without compromising the integrity of configuration files. Further details and discussions regarding the necessity and implementation of this enhancement are available in the associated issue.

revant commented 5 months ago

please fix the pre-commit / lint

0yeifer commented 5 months ago

Done :), I think so