search

frappe / frappejs

Node + Electron + Vue based metadata web framework (inspired by Frappe)
264 stars 110 forks source link

Please review translation.js code #163

Closed Helkyd closed 2 years ago

Helkyd commented 2 years ago

Found # and is returning error

translate(segment) {

// TODO: implement translation backend
return segment;

}

stitch() {

if (typeof this.args[0] === 'string') {
  return stringReplace(this.args[0], this.args.slice(1));
}
18alantom commented 2 years ago

Yup, I realised it when I restarted yarn electron:serve. For whatever reason, it was working when I made the changes whilst yarn electron:serve was running.

The issue seems to be some kinda bug that is preventing babel-loader from being used for transpiling the dependencies.

Due to this and other reasons, I'll be inlining frappejs code into books (the relevant parts): https://github.com/frappe/books/pull/320

18alantom commented 2 years ago

Closing this cause: https://github.com/frappe/frappejs/issues/164