search

frappe / gantt

Open Source Javascript Gantt
https://frappe.io/gantt
MIT License
4.71k stars 1.05k forks source link

Dependencies: moment #31

Closed hustcc closed 6 years ago

hustcc commented 7 years ago

Now, the dependencies moment is not require in the source code, so we need to import moment.js by script tag in html.

issues here on my project gantt-for-react, see below.

dineshbn commented 7 years ago

Use expose_loader to load the moment if u use web pack in your project.this will solve this issue.

ghost commented 6 years ago

Is this deliberately change to use global moment?

dineshbn commented 6 years ago

Yes, it loaded the moment globally.

hustcc commented 6 years ago

Put moment into peer, and import it in the source code.

I think this way maybe better.

hustcc commented 6 years ago

All the issue https://github.com/hustcc/gantt-for-react/issues?q=is%3Aissue+is%3Aclosed is about the dependency of moment.

netchampfaris commented 6 years ago

moment.js is not a dependency anymore 😄

hustcc commented 6 years ago

release new version gantt-for-react, use gantt@^2.0.0 as dependence.