search

frappe / gantt

Open Source Javascript Gantt
https://frappe.io/gantt
MIT License
4.71k stars 1.05k forks source link

fix: pop up not shown when progress bar is resized and README file update #334

Closed luizfboss closed 6 months ago

luizfboss commented 1 year ago

When this.gantt.bar_being_dragged is compared to null, there are no problems with showing the pop-up after resizing the progress bar.

Before changes: if (this.gantt.bar_being_dragged) return;

Before Changes

After changes: if (this.gantt.bar_being_dragged == null) return;

After Changes

Additionally, in set_action_completed(), it seems that the delay in setTimeout() is too big. By reducing it, the user can see the pop-up on the screen after resizing bars with no bugs. Values changed -> From 1000 to 200

These adjustments should solve issue https://github.com/frappe/gantt/issues/319

README.md file update: Enhancement of instructions in third step of Contributing Section.

Please let me know if everything works fine. Feedback is much appreciated. Thank you!

safwansamsudeen commented 6 months ago

Thanks for your PR! We've fixed this in #393.