search

frappe / gantt

Open Source Javascript Gantt
https://frappe.io/gantt
MIT License
4.6k stars 1.02k forks source link

chore: apply prettier formatting on all files #395

Open jledentu opened 4 months ago

jledentu commented 4 months ago

Hi!

Prettier is used to format files. But I noticed that the formatting was not actually applied on all files. This PR fixes that. This will avoid to have other Pull Requests polluted by large re-formats.

As explained in the Prettier documentation, it's recommended to set formatted files with .prettierignore rather than a file glob in prettier command:

It’s recommended to have a .prettierignore in your project! This way you can run prettier --write . to make sure that everything is formatted (without mangling files you don’t want, or choking on generated files). And – your editor will know which files not to format!

So I changed the prettier and prettier-check scripts to apply formatting on all files!

safwansamsudeen commented 4 months ago

Hi, we're totally revamping our tooling in #394, so this file structure no longer applies.

jledentu commented 4 months ago

Hi, we're totally revamping our tooling in #394, so this file structure no longer applies.

@safwansamsudeen Yeah, but your PR mixes formatting, bug fixes and tooling evolutions, and these distinct changes are not dependent to each other. I think you should split this work in several separate PRs. :wink: That's why I submit this PR which is totally independent to future upgrade to Vite.