frappe / hrms

Open Source HR and Payroll Software
https://frappe.io/hr
GNU General Public License v3.0
1.29k stars 667 forks source link

Employee import doesn't check for Duplicates #2013

Closed Ramesh-Udhyam closed 1 month ago

Ramesh-Udhyam commented 2 months ago

Information about bug

When I import employee information from another HR tool into ERPNext, the data import tool doesn't identify duplicate records based on typical identification fields like email, phone number or any other unique field. It simply creates the same employees again with new ERPNext IDs based on the naming series. What is the process for keeping the two systems in sync? I was thinking of downloading the complete list from the other system and import that into ERPNext every month? With no duplicate check and no insert and update process, this won't work!

Module

HR

Version

Version 15

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

Nihantra-Patel commented 2 months ago

This isn't an issue with the HR system; it's a problem with your code. If you create an employee using a naming series, the system won't check for unique employee names and other details. To handle this, you need to implement logic when integrating with other HR tools. Alternatively, you can set unique names for employees manually.

Ramesh-Udhyam commented 2 months ago

I didn't say it was an issue with the HR system. I was talking about the import tool itself. It would be a basic expectation to see some validations when the import is dealing with entities like "Employee". It should at least give options to create validations, ignore certain errors, etc, so that it is a robust import process. Right now, if someone imports the same file twice by mistake, the system will simply create duplicate employees in the system, deleting of which will become a tedious process. As an example, if the import process encounters the same email address, shouldn't it throw an error?

On Mon, 29 Jul 2024 at 15:43, Nihantra C. Patel @.***> wrote:

This isn't an issue with the HR system; it's a problem with your code. If you create an employee using a naming series, the system won't check for unique employee names and other details. To handle this, you need to implement logic when integrating with other HR tools. Alternatively, you can set unique names for employees manually.

— Reply to this email directly, view it on GitHub https://github.com/frappe/hrms/issues/2013#issuecomment-2255537356, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJ6PF3F3EZSQP5R6AUTRHCLZOYIWBAVCNFSM6AAAAABLT6IBHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJVGUZTOMZVGY . You are receiving this because you authored the thread.Message ID: @.***>

ruchamahabal commented 1 month ago

You can go to customize form and mark some field as unique like email ID in the employee master https://docs.erpnext.com/docs/user/manual/en/customize-form

Closing this as its not a bug