frappe / hrms

Open Source HR and Payroll Software
https://frappe.io/hr
GNU General Public License v3.0
1.38k stars 714 forks source link

Monthly Attendance Sheet On-Duty is as Work From Home #971

Open sjain17 opened 1 year ago

sjain17 commented 1 year ago

Information about bug

Monthly Attendance Sheet On-Duty is as Work From Home, however, it should show OD or On-Duty as per the selected reason. The report becomes confusing in case the employee was on on-duty and it shows WFH.

Module

HR

Version

ERPNext: v14.44.0 (HEAD)

Frappe Framework: v14.52.0 (HEAD)

Frappe HR: v14.13.1 (HEAD)

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

ruchamahabal commented 1 year ago

@sjain17 attendance sheet pulls data from attendance records, so if you have created an Attendance record as "Work from Home" it will show up as that. If you don't want it to show up as WFH, mark WFH as present in records.

this cannot be overridden in the core

sjain17 commented 1 year ago

WFH is fine but when we mark attendance request with reason On Duty then it shows as present in Monthly Attendance sheet whereas it should as OD instead of Present. Screenshot 2023-10-13 at 2 52 48 PM

ruchamahabal commented 1 year ago

Oh, so you are marking attendance from Attendance Request. Yeah so On Duty of Attendance Request essentially marks attendance as Present. That shouldn't be a problem, right?

What's the exact use-case for which you want this? Do you want a flag in the Attendance Sheet to show you whether this record was marked via an attendance request under a column "via Attendance Request"?

sjain17 commented 1 year ago

For example - An employee was out of the office for 10 days due to a business trip. Now if we create an attendance request for those 10 days with reason equal On Duty and submit it, it generates attendance upon submission with status =Present. However, marking the same attendance request with a reason equal to WFH creates attendance with WFH status and not as Present.

In the Monthly attendance sheet, 10 days that are marked as On-Duty (created via attendance request) show as Present which I wanted to see as OD instead of Present. It would be better if we have another status of OD in the monthly attendance report to verify the OD days vs Actual Present. Attached screenshot shows the present of employee which was created via attendance request and reason as On Duty.

Screenshot 2023-10-13 at 3 48 23 PM

mohdjaveed123 commented 9 months ago

@ruchamahabal @sjain17 @venetanji @rmehta @SaiFi0102

hello

any body help me.

how create weekly roster? if any body know tell me step by step. In company have 3 different time shift have, this 3 shift is different different days need to assign. I create shift type. but I unable to find week days assign shift type. like below pic.

        **Roster plan**         

Day Shift Name IN OUT Monday General-shift 10 AM 5PM Tuesday General-shift 10 AM 5PM Wednesday General-shift 10 AM 5PM Thursday General-shift 10 AM 5PM Friday Friday-shift 9AM 1PM Saturday Saturday-shift 9AM 2PM Sunday Week-Off

Roster Plan

Roster Plan2