frappe / insights

Open source analytics / business intelligence tool (BI)
https://frappe.io/insights
GNU Affero General Public License v3.0
406 stars 199 forks source link

Progress Target Switcher Fix #290

Open rdr6000 opened 1 month ago

rdr6000 commented 1 month ago

The progress target switcher had a bug where if the props.tabs?.[0] == 'string' was false, no value property would be created, which in turn would send undefined in this emit emit('update:modelValue', tab.value) . Instead we can just return emit('update:modelValue', tab)

This directly works with @update:model-value="$emit('tab-change', $event.label)" in InputWithTabs.vue.

Target Tab switching is working in Progess after this change