search

frappe / lms

Easy to Use, 100% Open Source Learning Management System
https://frappe.io/learning
GNU Affero General Public License v3.0
1.06k stars 486 forks source link

Issue: Mandatory Fields Not Displaying Asterisk Marks in Frappe LMS #1026

Closed abhirock74 closed 3 weeks ago

abhirock74 commented 2 months ago

Issue: Mandatory Fields Not Displaying Asterisk Marks in Frappe LMS

Description

When creating or editing records in Frappe LMS, the mandatory fields should be marked with a red asterisk (*) to indicate that they are required. However, these asterisk marks are not visible, which may cause users to overlook required fields.

Expected Behavior

Mandatory fields should display a red asterisk (*) to indicate that the field is required.

Actual Behavior

Mandatory fields are not showing any visual indication (asterisk) that they are required.

Screenshots

Provide screenshots or GIFs of the issue if possible. Screenshot from 2024-09-23 11-43-08 Screenshot from 2024-09-23 11-43-23

anees264 commented 1 month ago

Just a doubt, I checked the Instructor table, It's empty, and where do we add Instructors? without Instructor data, It's not allowing to create a course! @pateljannat

abhirock74 commented 1 month ago

@anees264 search Instructors name then you will find a list . image

I hope it help you @anees264

spitoglou commented 1 month ago

Hello. Since the instructor table is empty, how could it provide a search-based list? I am experiencing the same problem with @anees264 ...

iamejaaz commented 1 month ago

Hello. Since the instructor table is empty, how could it provide a search-based list? I am experiencing the same problem with @anees264 ...

Instructor fetches from the user Doctype type so you have to create a user first.

iamejaaz commented 1 month ago

@abhirock74 The reason it is not displaying an asterisk in required fields is that this page uses Frappe UI, and Frappe UI does not have an option to show asterisks in required fields.

abhirock74 commented 1 month ago

@iamejaaz Is any other way to show asterisk because it is confusing for users.

iamejaaz commented 1 month ago

@iamejaaz Is any other way to show asterisk because it is confusing for users.

@abhirock74 To do that, we have to change the code in the CourseForm.vue file. This will be a temporary solution; if the moderator of this app allows it, then I am ready to raise a PR. image image

abhirock74 commented 1 month ago

@iamejaaz Thank you .

pateljannat commented 1 month ago

@iamejaaz a right fix would be to the FormControl field in Frappe UI

iamejaaz commented 1 month ago

@iamejaaz a right fix would be to the FormControl field in Frappe UI

Created PR in Frappe UI https://github.com/frappe/frappe-ui/pull/193

frappe-pr-bot commented 2 weeks ago

:tada: This issue has been resolved in version 2.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: