search

frappe / lms

Easy to Use, 100% Open Source Learning Management System
https://frappe.io/learning
GNU Affero General Public License v3.0
1.06k stars 479 forks source link

fix: time field issue in edit batch form #1107

Open iamejaaz opened 1 week ago

iamejaaz commented 1 week ago

Closes #1103

Before

image

After

image

cypress[bot] commented 1 week ago

lms    Run #796

Run Properties:  status check passed Passed #796  •  git commit 4f2d21f107 ℹ️: Merge 5febe9e9bdf6576684177cd3b1c6608b662640c3 into c5f091fae8a6bb588fcf06b66e8f...
Project lms
Branch Review time-field-issue
Run status status check passed Passed #796
Run duration 00m 30s
Commit git commit 4f2d21f107 ℹ️: Merge 5febe9e9bdf6576684177cd3b1c6608b662640c3 into c5f091fae8a6bb588fcf06b66e8f...
Committer Ejaaz Khan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
pateljannat commented 1 week ago

@iamejaaz I don't understand the issue you are trying to solve here. The time field works properly currently. What exactly is the issue you are facing?

Screenshot 2024-11-12 at 11 58 28 AM
iamejaaz commented 1 week ago

@iamejaaz I don't understand the issue you are trying to solve here. The time field works properly currently. What exactly is the issue you are facing?

@pateljannat Please try selecting an AM time and check, as I showed the issue in the video. When I select an AM time, like 12 AM or 1 AM, it does not display in the edit form.