search

frappe / press

Full service cloud hosting for the Frappe stack - powers Frappe Cloud
https://frappe.cloud
GNU Affero General Public License v3.0
259 stars 187 forks source link

fix : Faulty deploy status post image build while remote image push #1924

Closed arunmathaisk closed 1 week ago

arunmathaisk commented 3 months ago

fixes #1923

Even though the sanity parse code is written to rightfully check for the error in the response of docker sdk. While setting self._set_status_failure() for failure cases, the returned value "Error" is missed.

https://github.com/frappe/press/blob/master/press/press/doctype/deploy_candidate/docker_output_parsers.py#L288-L309