search

frappe / press

Full service cloud hosting for the Frappe stack - powers Frappe Cloud
https://frappe.cloud
GNU Affero General Public License v3.0
259 stars 187 forks source link

prometheus query URL wrong? #2101

Closed casesolved-co-uk closed 1 month ago

casesolved-co-uk commented 1 month ago

I'm not sure how this works because the nginx proxy puts prometheus at: /metrics/prometheus

https://github.com/frappe/press/blob/28e022c2705f0dd9fa2b4befb0c544e3d84717a7/press/api/server.py#L328

The prometheus service is started with --web.external-url=https://<server>/prometheus but it appears this is supposed to match the nginx location?

casesolved-co-uk commented 1 month ago

Never mind, hadn't realised the agent nginx config is optional depending on server:

https://github.com/frappe/agent/blob/master/agent/templates/agent/nginx.conf.jinja2