Open cogk opened 2 months ago
A patch could be written to set the value back in Press Settings if migration needs to be automatic.
boto3_offsite_backup_session
for auditAttention: Patch coverage is 16.66667%
with 35 lines
in your changes missing coverage. Please review.
Project coverage is 39.90%. Comparing base (
ee3fe50
) to head (72b56a8
).
Files with missing lines | Patch % | Lines |
---|---|---|
press/press/doctype/remote_file/remote_file.py | 3.33% | 29 Missing :warning: |
press/api/site.py | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Don't hardcode endpoint and region for S3 buckets
There were many references to the
ap-south-1
region and a global implicit reference to AWS. This PR contains refactors of the S3 bucket systems for "offsite backups", "dashboard uploads" and "Backup Bucket doctype" buckets, to avoid vendor lock-in.I tried my best to make it backwards compatible with what I assume is the configuration on Frappe Cloud, but I can't check.
Details:
offsite_backups_endpoint
,remote_uploads_region
,remote_uploads_endpoint
offsite_backups_provider
(replaced by endpoint),data_40
(typo probably)cc: @gavindsouza :wave:re: https://github.com/frappe/press/pull/19 https://github.com/frappe/press/pull/22For the Frappe team
uploads.frappe.cloud
URL somewhere, I just kept it unchanged, but the refactor won't be truly finished until a migration path can be found for you.Typical configuration values for the fields
AWS S3 (Fallback/Legacy)
ap-south-1
https://s3.amazonaws.com
)AWS S3
ap-south-1
https://s3.ap-south-1.amazonaws.com
(possibly a custom DNS name such asuploads.example.com
)OVH
de
https://storage.de.cloud.ovh.net