frappe / press

Full service cloud hosting for the Frappe stack - powers Frappe Cloud
https://frappe.cloud
GNU Affero General Public License v3.0
278 stars 195 forks source link

chore: rename bench #2180

Closed 18alantom closed 1 month ago

18alantom commented 1 month ago

ToDo:

"Bench" will be renamed such that:

Why?: "Bench" on the dashboard refers to the Release Group doctype. This causes immense confusion because there also exists a Bench doctype.

The objects of Bench are shown UI side (under the Site list), but they can't be called "Bench" because that already refers to something else.

This ends up being a hinderance when it comes to support, writing documentation, etc. It is also a hinderance when it comes to development because in dashboard code Release Group objects are referred to both as bench and as release group. This asinine naming causes conceptual-confusion on all sides and we end up with a kind of tower-of-babel like problem.

Finally, if we are to show Bench analytics on the dashboard, we'd be worsening the problem by using other terms instead of "Bench". So this is a necessary pre-req.

Note: as of now benches/bench-XXXX route will remain the same.

Notes:

18alantom commented 1 month ago

Broken test unrelated to PR. Will complete the last to-do (renaming in code references, mainly variables) in the next PR. Merging this.