search

frappe / press

Full service cloud hosting for the Frappe stack - powers Frappe Cloud
https://frappe.cloud
GNU Affero General Public License v3.0
279 stars 195 forks source link

fix(testcase): broken tests in CI #2214

Closed tanmoysrt closed 1 month ago

tanmoysrt commented 1 month ago

Tests were broken mainly due to changes in framework https://github.com/frappe/frappe/pull/28044 Also, there were few testcases, which was broken due to some recent changes. Those has been fixed.

Few testcases (ref) added for this site plan override based on type of server (public or dedicated) (ref).

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.62%. Comparing base (8c5eca6) to head (cafc9ad). Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
press/tests/before_test.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2214 +/- ## ========================================== - Coverage 36.75% 36.62% -0.13% ========================================== Files 368 368 Lines 30667 30823 +156 ========================================== + Hits 11271 11289 +18 - Misses 19396 19534 +138 ``` | [Flag](https://app.codecov.io/gh/frappe/press/pull/2214/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=frappe) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/frappe/press/pull/2214/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=frappe) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=frappe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tanmoysrt commented 1 month ago

The deprecation wouldn't fail CI due to this update in framework https://github.com/frappe/frappe/pull/28103 Closing it for now. Re-open, if required to move to latest version.