frappe / press

Full service cloud hosting for the Frappe stack - powers Frappe Cloud
https://frappe.cloud
GNU Affero General Public License v3.0
279 stars 195 forks source link

fix(RemoteFile): Don't try to delete unavailable S3 file #2259

Open cogk opened 2 weeks ago

cogk commented 2 weeks ago

If I'm not mistaken, unavailable Remote Files could be removed (like other Log Types) once they become unavailable.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.94%. Comparing base (2f435f8) to head (b6b667a).

Files with missing lines Patch % Lines
press/press/doctype/remote_file/remote_file.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2259 +/- ## ========================================== - Coverage 29.94% 29.94% -0.01% ========================================== Files 371 371 Lines 28078 28079 +1 ========================================== Hits 8408 8408 - Misses 19670 19671 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.