Open NagariaHussain opened 2 years ago
This can be done in general as well and not only for Marketplace apps.
Have a child table in Marketplace App for App Dependencies
a better implementation would be to make it general by adding a child table in the App source maybe?
a better implementation would be to make it general by adding a child table in the App source maybe?
Let's start with marketplace apps only.
It will be harder to start with apps in general (permission issues, private app source etc.)
We can figure that out later or maybe it should be done in FF level.
Make sure it's somewhat consistent with dependency resolution that already exists: https://github.com/frappe/bench/pull/1257
required_apps
hook is used for this in some apps already.
Make sure it's somewhat consistent with dependency resolution that already exists: https://github.com/frappe/bench/pull/1257
required_apps
hook is used for this in some apps already.
FC should be able to read those hooks while app source is added I think. So, we can track them better in FC when bench tries to install dep apps.
Currently, there is no way we can prevent the user from installing an app without its dependent app. For example, you can't install India Compliance without ERPNext, you can't have Restaurant Management app without the Frappe Helper app, etc.
Here is what we can do: